[FEATURE] Make hll and minhash sketches cerealisable #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
seqan-actions
added
lint
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
=======================================
Coverage 99.68% 99.68%
=======================================
Files 49 49
Lines 1912 1912
Branches 5 5
=======================================
Hits 1906 1906
Misses 6 6 ☔ View full report in Codecov by Sentry. |
seqan-actions
added
lint
smehringer
force-pushed
the
sketch_file
branch
from
c8bc20a
to
ad59449
Compare
eseiler
approved these changes
Aug 19, 2024
seqan-actions
added
lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading and writing now works in chopper with this branch on a test data set. I did not test it on the big data, as a benchmark is running and all the data is on augustus.
I will check it before doing the PR for chopper, but this minor PR for the HIBF lib could already be reviewed/merged.